Skip to content

Conversation

namgyu-youn
Copy link
Contributor

@namgyu-youn namgyu-youn commented Sep 14, 2025

Summary:
This is a milestone for building a benchmark for AWQ/SmoothQuant within the vLLM ecosystem (#2815). For vLLM benchmark, AWQ/SmoothQuant needs a wrapper (TransformerEvalWrapper) to be compatible with vLLM. Therefore, this PR adds unit test to verify if TransformerEvalWrapper works with AWQ/SmoothQuant.

Test plan:
A toy tokenizer model is introduced to validate TransformerEvalWrapper. Toy linear models are updated to be compatible with the tokenizer model.

Future plan:
This PR only validates the wrapper for the benchmark within the vLLM ecosystem. We need to expand metrics for comprehensive AWQ/SmoothQuant benchmarks.

Introduce a prototype AWQ/SmoothQuant benchmark within lm_eval (vLLM).

Related Issue/PR: pytorch#2815

Test plan:
A toy tokenizer model is introduced to validate `TransformerEvalWrapper`.
Toy linear models are updated to be compatible with the tokenizer model.

Updated unit tests (`test_awq.py` and `test_smoothquant.py`) address the
above changes.

Future plan:
This PR doesn't address latency and consumption. We need to expand metrics
for comprehensive benchmarks within AWQ/SmoothQuant.
Copy link

pytorch-bot bot commented Sep 14, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/3000

Note: Links to docs will display an error until the docs builds have been completed.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 14, 2025
@namgyu-youn namgyu-youn marked this pull request as draft September 15, 2025 16:01
@namgyu-youn namgyu-youn marked this pull request as ready for review September 16, 2025 09:32
@namgyu-youn namgyu-youn changed the title Add AWQ/SmoothQuant wrapper test case for vLLM benchmark. Add AWQ/SmoothQuant evaluation wrapper test for vLLM benchmark Sep 18, 2025
@namgyu-youn namgyu-youn changed the title Add AWQ/SmoothQuant evaluation wrapper test for vLLM benchmark Build unit test for AWQ/SmoothQuant wrapper Sep 22, 2025
Copy link
Contributor

@jerryzh168 jerryzh168 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine, also we could just test on real models through the release scripts I think

@namgyu-youn namgyu-youn marked this pull request as draft October 9, 2025 12:47
@namgyu-youn namgyu-youn changed the title Build unit test for AWQ/SmoothQuant wrapper Parameterize AWQ config, device Oct 9, 2025
@namgyu-youn
Copy link
Contributor Author

namgyu-youn commented Oct 9, 2025

Removed the tokenizer because too many errors made AWQ api reproducible, mostly dispatch errors; just testing real models without ToyTokenizer seems better and close this PR.

@namgyu-youn namgyu-youn marked this pull request as ready for review October 9, 2025 13:34
@namgyu-youn namgyu-youn requested a review from jerryzh168 October 9, 2025 13:34
@namgyu-youn namgyu-youn changed the title Parameterize AWQ config, device Parameterize AWQ config, device for unit test Oct 9, 2025
@namgyu-youn namgyu-youn changed the title Parameterize AWQ config, device for unit test Parameterize AWQ config, device in unit test Oct 9, 2025
@namgyu-youn namgyu-youn changed the title Parameterize AWQ config, device in unit test Add AWQ/SmoothQuant evaluation wrapper test for vLLM benchmark Oct 10, 2025
@namgyu-youn namgyu-youn deleted the vllm-benchmark branch October 10, 2025 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants